✨ Split SDK helper contracts#256
Merged
Merged
Conversation
Carve the SDK, client, and low-level helper contract changes into their own reviewable slice.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Why: the first stack slice should validate on its own instead of reaching into the later uploader-boundary PR. Keep the SDK public factory wired to the existing uploader service until that boundary is migrated in its dedicated slice.
Robdel12
force-pushed
the
rd/cli-audit-sdk-helpers
branch
from
3defb01 to
8b9bcbf
Compare
Vizzly - Visual Test ResultsCLI Reporter - 1 change needs review
Changes needing review (1)fullscreen-viewer · Firefox · 375×667 · 78.5% diff
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The SDK and browser client are the public entrypoints people build around, so they need to be the most boring part of the CLI: stable config handling, predictable helper behavior, and type definitions that match the actual runtime. Before this split, a lot of that logic lived inline or behind implicit behavior, which made later command and server cleanup harder to review safely.
This PR establishes the small shared helper contracts first. That gives the rest of the stack a clean base for URL normalization, screenshot option normalization, timeout behavior, wildcard matching, and SDK service creation without pulling unrelated command/server changes into the same review.
What Changed
Verification
npm run buildnpm run test:typesnode --test tests/utils/api-url.test.js tests/utils/async-utils.test.js tests/utils/fetch-utils.test.js tests/utils/patterns.test.js tests/utils/screenshot-options.test.js tests/sdk/client.test.js tests/sdk/index.test.js tests/api/endpoints.test.jsStack
1/10 in the CLI audit stack.
Base:
mainHead:
rd/cli-audit-sdk-helpers